]> git.earman.xyz Git - sensor-watch.git/commitdiff
static analysis: add comments to empty while loops
authorJoey Castillo <joeycastillo@utexas.edu>
Sun, 10 Apr 2022 19:07:58 +0000 (15:07 -0400)
committerJoey Castillo <joeycastillo@utexas.edu>
Sun, 10 Apr 2022 19:08:47 +0000 (15:08 -0400)
watch-library/hardware/watch/watch_adc.c
watch-library/hardware/watch/watch_deepsleep.c
watch-library/hardware/watch/watch_private.c

index c8c4d65a68db07fdd2ce7b6ce123b58ba6833308..476f0cbbcb018a48c87bfe649210b984cdb04a48 100644 (file)
@@ -36,7 +36,7 @@ static uint16_t _watch_get_analog_value(uint16_t channel) {
     }
 
     ADC->SWTRIG.bit.START = 1;
-    while (!ADC->INTFLAG.bit.RESRDY);
+    while (!ADC->INTFLAG.bit.RESRDY); // wait for "result ready" flag
 
     return ADC->RESULT.reg;
 }
index e3f654f216cc5c41d067674fd678927c81785761..b1b5b2c9f44792adf14249cc25eab6310fa0ae22 100644 (file)
@@ -69,7 +69,7 @@ void watch_register_extwake_callback(uint8_t pin, ext_irq_cb_t callback, bool le
 
     // disable the RTC
     RTC->MODE2.CTRLA.bit.ENABLE = 0;
-    while (RTC->MODE2.SYNCBUSY.bit.ENABLE);
+    while (RTC->MODE2.SYNCBUSY.bit.ENABLE); // wait for RTC to be disabled
 
     // update the configuration
     RTC->MODE2.TAMPCTRL.reg = config;
index 241ff40a21e4ff75fbc4259f72f225ab532098a8..2bb3d812459fd254ca5a611ceaaa0972ac20a4ee 100644 (file)
@@ -35,7 +35,7 @@ void _watch_init(void) {
 
     // Use switching regulator for lower power consumption.
     SUPC->VREG.bit.SEL = 1;
-    while(!SUPC->STATUS.bit.VREGRDY);
+    while(!SUPC->STATUS.bit.VREGRDY); // wait for voltage regulator to become ready
 
     // check the battery voltage...
     watch_enable_adc();
@@ -63,7 +63,7 @@ void _watch_init(void) {
     SUPC->BOD33.bit.LEVEL = 34;     // Detect brownout at 2.6V (1.445V + level * 34mV)
     SUPC->BOD33.bit.ACTION = 0x2;   // Generate an interrupt when BOD33 is triggered
     SUPC->BOD33.bit.HYST = 0;       // Disable hysteresis
-    while(!SUPC->STATUS.bit.B33SRDY);
+    while(!SUPC->STATUS.bit.B33SRDY); // wait for BOD33 to sync
 
     // Enable interrupt on BOD33 detect
     SUPC->INTENSET.bit.BOD33DET = 1;
@@ -198,7 +198,7 @@ void _watch_enable_usb(void) {
 
     // assign DFLL to GCLK1
     GCLK->GENCTRL[1].reg = GCLK_GENCTRL_SRC(GCLK_GENCTRL_SRC_DFLL48M) | GCLK_GENCTRL_DIV(1) | GCLK_GENCTRL_GENEN;// | GCLK_GENCTRL_OE;
-    while (GCLK->SYNCBUSY.bit.GENCTRL1);
+    while (GCLK->SYNCBUSY.bit.GENCTRL1); // wait for generator control 1 to sync
 
     // assign GCLK1 to USB
     hri_gclk_write_PCHCTRL_reg(GCLK, USB_GCLK_ID, GCLK_PCHCTRL_GEN_GCLK1_Val | GCLK_PCHCTRL_CHEN);