]> git.earman.xyz Git - sensor-watch.git/commitdiff
restore old light button behavior
authorJeremy O'Brien <neutral@fastmail.com>
Thu, 26 Jan 2023 15:44:11 +0000 (10:44 -0500)
committerjoeycastillo <joeycastillo@utexas.edu>
Fri, 27 Jan 2023 15:43:03 +0000 (09:43 -0600)
watch faces that handle EVENT_LIGHT_BUTTON_UP but not EVENT_LIGHT_BUTTON_DOWN
probably don't want the default EVENT_LIGHT_BUTTON_DOWN LED activation behavior

22 files changed:
movement/watch_faces/clock/mars_time_face.c
movement/watch_faces/complication/alarm_face.c
movement/watch_faces/complication/blinky_face.c
movement/watch_faces/complication/countdown_face.c
movement/watch_faces/complication/databank_face.c
movement/watch_faces/complication/interval_face.c
movement/watch_faces/complication/morsecalc_face.c
movement/watch_faces/complication/probability_face.c
movement/watch_faces/complication/rpn_calculator_alt_face.c
movement/watch_faces/complication/rpn_calculator_face.c
movement/watch_faces/complication/sailing_face.c
movement/watch_faces/complication/ships_bell_face.c
movement/watch_faces/complication/tachymeter_face.c
movement/watch_faces/complication/tarot_face.c
movement/watch_faces/complication/tomato_face.c
movement/watch_faces/complication/wake_face.c
movement/watch_faces/demo/frequency_correction_face.c
movement/watch_faces/sensor/accelerometer_data_acquisition_face.c
movement/watch_faces/settings/finetune_face.c
movement/watch_faces/settings/nanosec_face.c
movement/watch_faces/settings/set_time_face.c
movement/watch_faces/settings/set_time_hackwatch_face.c

index ae39e696e94545ec11e7bd62c70570d6197636e2..30f6a34b02bb0714932f664f75b9dba1c2e6c6a4 100644 (file)
@@ -148,6 +148,9 @@ bool mars_time_face_loop(movement_event_t event, movement_settings_t *settings,
             // TODO: low energy update
             // watch_start_tick_animation(500);
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index 479f2f1ee30fc9ac3d8f5b46bf1290d19abd639f..3b7d1e35ee6602e60b2dec2c7f8d117687b35673 100644 (file)
@@ -444,6 +444,9 @@ bool alarm_face_loop(movement_event_t event, movement_settings_t *settings, void
     case EVENT_TIMEOUT:
         movement_move_to_face(0);
         break;
+    case EVENT_LIGHT_BUTTON_DOWN:
+        // don't light up every time light is hit
+        break;
     default:
         movement_default_loop_handler(event, settings);
         break;
index dc3c8ab02f092e02c900647b2e610924b75d4a1b..2deafc6844422fc31f2ae2c6a5c32093c26586e8 100644 (file)
@@ -57,7 +57,7 @@ bool blinky_face_loop(movement_event_t event, movement_settings_t *settings, voi
         case EVENT_ACTIVATE:
             _blinky_face_update_lcd(state);
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             if (!state->active) {
                 state->color = (state->color + 1) % 3;
                 _blinky_face_update_lcd(state);
index 15fc375d13f7afc8bdf1cfdf9f494a40c14deeb5..4c3859da316f604f43a8b65016bc744bafa91ebd 100644 (file)
@@ -225,7 +225,7 @@ bool countdown_face_loop(movement_event_t event, movement_settings_t *settings,
             abort_quick_ticks(state);
             movement_move_to_next_face();
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             switch(state->mode) {
                 case cd_running:
                     movement_illuminate_led();
index c32d696267d8fbd1aa085e12610b6d76ca05fd7a..9bc22da91646b53fea50fb445bb535e29179849a 100644 (file)
@@ -136,6 +136,9 @@ bool databank_face_loop(movement_event_t event, movement_settings_t *settings, v
             // won't be on screen, and thus opts us out of getting the EVENT_LOW_ENERGY_UPDATE above.
             movement_move_to_face(0);
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index 1f982d3abab5519693b12822d51b864ff34afced..e8ebe32153fb74c4254d176c0f9bd82bc7b5c632 100644 (file)
@@ -667,6 +667,9 @@ bool interval_face_loop(movement_event_t event, movement_settings_t *settings, v
     case EVENT_TIMEOUT:
         if (state->face_state != interval_state_running) movement_move_to_face(0);
         break;
+    case EVENT_LIGHT_BUTTON_DOWN:
+        // don't light up every time light is hit
+        break;
     default:
         movement_default_loop_handler(event, settings);
         break;
index c54c0ead1705606944a7a3a56fe2b4a0c282600a..cdf0e1988ac0826ea809ebc510eef1b47d176ebd 100644 (file)
@@ -376,6 +376,12 @@ bool morsecalc_face_loop(movement_event_t event, movement_settings_t *settings,
                                settings->bit.led_green_color ? (0xF | settings->bit.led_green_color << 4) : 0);
                }
         break;
+    case EVENT_LIGHT_BUTTON_DOWN:
+        // don't light up every time light is hit
+        break;
+    default:
+        movement_default_loop_handler(event, settings);
+        break;
        }
     
     return true;
index 00d1d6d7d95166bc7e2981af5965d9385ff5d9d4..79427019892e70a2f4d887eacb8ca014bb78c19d 100644 (file)
@@ -141,7 +141,7 @@ bool probability_face_loop(movement_event_t event, movement_settings_t *settings
         case EVENT_TICK:
             display_dice_roll_animation(state);
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             // Change how many sides the die has
             for (int i = 0; i < NUM_DICE_TYPES; i++) {
                 if (DICE_TYPES[i] == state->dice_sides) {
index ad7ef900e988bc3d3f0d49ba37986bd2ebbadfe5..e48efe834c76959fe342657867a59bf4a32c512f 100644 (file)
@@ -402,7 +402,7 @@ bool rpn_calculator_alt_face_loop(movement_event_t event, movement_settings_t *s
                 return false;
             }
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             proposed_stack_size = s->stack_size - functions[s->fn_index].input;
 
             if (s->mode == CALC_NUMBER) {
index 2047971bd9c72a7bacf05df06c92ac224b328d8d..e1b2dfd83ca0df9858958bca42eb1cf3e289b8a2 100644 (file)
@@ -280,7 +280,7 @@ bool rpn_calculator_face_loop(movement_event_t event, movement_settings_t *setti
                 break;
             }
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             switch (state->mode) {
                 case rpn_calculator_waiting:
                     state->mode = rpn_calculator_op;
index 81d99db1b2fcf0ba828e2db28fad4703af680ccd..792f158166a1680cae899e437c2b9c884df951e5 100644 (file)
@@ -255,6 +255,9 @@ bool sailing_face_loop(movement_event_t event, movement_settings_t *settings, vo
             break;
         case EVENT_LOW_ENERGY_UPDATE:
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index fbcfea8f6b8d4b65147e72f4c36eb895e2e4872b..3ce11f90335cd20c978effac9cf1b8f198aa8f85 100644 (file)
@@ -92,12 +92,6 @@ bool ships_bell_face_loop(movement_event_t event, movement_settings_t *settings,
         case EVENT_TICK:
             ships_bell_draw(state);
             break;
-        case EVENT_MODE_BUTTON_UP:
-            movement_move_to_next_face();
-            break;
-        case EVENT_LIGHT_BUTTON_UP:
-            movement_illuminate_led();
-            break;
         case EVENT_ALARM_BUTTON_UP:
             state->bell_enabled = !state->bell_enabled;
             if (state->bell_enabled) watch_set_indicator(WATCH_INDICATOR_BELL);
@@ -122,6 +116,7 @@ bool ships_bell_face_loop(movement_event_t event, movement_settings_t *settings,
             }
             break;
         default:
+            movement_default_loop_handler(event, settings);
             break;
     }
 
index 2b0a67cdb3cc6afc335641f99e24a42d76ce46df..ea69b2af4e03b6fa40222ce2cb3c128a14bdc73a 100644 (file)
@@ -250,6 +250,9 @@ bool tachymeter_face_loop(movement_event_t event, movement_settings_t *settings,
             // You should also consider starting the tick animation, to show the wearer that this is sleep mode:
             // watch_start_tick_animation(500);
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index 62d6f8405371fccafe0ac4cc18f09f007b9d39fe..44b01de4c25da94cb0ba3e915d88b1b5c871bf02 100644 (file)
@@ -284,6 +284,9 @@ bool tarot_face_loop(movement_event_t event, movement_settings_t *settings, void
         case EVENT_LOW_ENERGY_UPDATE:
             watch_display_string("SLEEP ", 4);
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index f96f52e240d7966e9c7656e1880a70aed8b58c3b..698301e1c076ec6a5a6e0d95c0075fce42bc38da 100644 (file)
@@ -142,7 +142,7 @@ bool tomato_face_loop(movement_event_t event, movement_settings_t *settings, voi
             }
             tomato_draw(state);
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             movement_illuminate_led();
             if (state->mode == tomato_ready) {
                 if (state->kind == tomato_break) {
index c94b916bbe10ae5f1f7c57911a696378820cee51..5c5f86be5aac01fad5364df405fd922856c5a802 100644 (file)
@@ -149,6 +149,9 @@ bool wake_face_loop(movement_event_t event, movement_settings_t *settings, void
         break;
     case EVENT_LOW_ENERGY_UPDATE:
         break;
+    case EVENT_LIGHT_BUTTON_DOWN:
+        // don't light up every time light is hit
+        break;
     default:
         movement_default_loop_handler(event, settings);
         break;
index 3fdef7eef5cf682ff45aa0015cea5e74df74ce84..17457177c079830fc7a835d61a28b2472d7adf1c 100644 (file)
@@ -96,7 +96,7 @@ bool frequency_correction_face_loop(movement_event_t event, movement_settings_t
             break;
         case EVENT_TICK:
             break;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             freqcorr = RTC->MODE2.FREQCORR.reg;
             if (freqcorr < 127) {
                 RTC->MODE2.FREQCORR.reg++;
index 80f09f7c0267dd1f2d587258ee5d1895a98e1fe6..6d174d5a667bf89f84f807c8a7fde3b10379a804 100644 (file)
@@ -214,6 +214,9 @@ bool accelerometer_data_acquisition_face_loop(movement_event_t event, movement_s
                 update_settings(state);
             }
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index 89c816657841f94f1bf1d2fff5e764981f213c4d..3b326b931c650c3a29ec22c0c36e42742af3afbe 100644 (file)
@@ -238,6 +238,9 @@ bool finetune_face_loop(movement_event_t event, movement_settings_t *settings, v
             // watch_start_tick_animation(500);
             break;
 
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index 6bfe29c4087b65f5cdc7c6e9a62e7f1c7df376c8..87f567d3dfbb76b2b4946d6389da0b4355083640 100644 (file)
@@ -364,6 +364,9 @@ bool nanosec_face_loop(movement_event_t event, movement_settings_t *settings, vo
 
             apply_RTC_correction(correction);
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;
index bfaea9fc029d43c32265b6dd19a8790939214042..61913430a7367c4ada87b1ce85e5269d4110f267 100644 (file)
@@ -115,7 +115,7 @@ bool set_time_face_loop(movement_event_t event, movement_settings_t *settings, v
             _abort_quick_ticks();
             movement_move_to_next_face();
             return false;
-        case EVENT_LIGHT_BUTTON_UP:
+        case EVENT_LIGHT_BUTTON_DOWN:
             current_page = (current_page + 1) % SET_TIME_FACE_NUM_SETTINGS;
             *((uint8_t *)context) = current_page;
             break;
index 0ad75049f040257b87ed0e9f1dfc72295b9ceabd..c65e2ffc0fe47fcbabc07e810aa2d63a66735c22 100644 (file)
@@ -200,6 +200,9 @@ bool set_time_hackwatch_face_loop(movement_event_t event, movement_settings_t *s
         case EVENT_TIMEOUT:
             movement_move_to_face(0);
             break;
+        case EVENT_LIGHT_BUTTON_DOWN:
+            // don't light up every time light is hit
+            break;
         default:
             movement_default_loop_handler(event, settings);
             break;