From: David Volovskiy <devolov@gmail.com>
Date: Sat, 24 Aug 2024 02:25:02 +0000 (-0400)
Subject: Additional code review change
X-Git-Url: https://git.earman.xyz/?a=commitdiff_plain;h=d5a8c57c8256433c11ea1b5b88f0d4900f20d697;p=sensor-watch.git

Additional code review change
---

diff --git a/movement/movement.c b/movement/movement.c
index b49ae7b..c81e0a7 100644
--- a/movement/movement.c
+++ b/movement/movement.c
@@ -681,10 +681,15 @@ static void debounce_btn_press(uint8_t pin, uint8_t *debounce_ticks, uint16_t *d
         *down_timestamp = 0;
 }
 
+static void disable_if_needed(uint8_t *ticks) {
+    if (*ticks > 0 && --*ticks == 0)
+        _movement_disable_fast_tick_if_possible();
+}
+
 static void movement_disable_if_debounce_complete(void) {
-    if (movement_state.debounce_ticks_light > 0 && --movement_state.debounce_ticks_light == 0) _movement_disable_fast_tick_if_possible();
-    if (movement_state.debounce_ticks_alarm > 0 && --movement_state.debounce_ticks_alarm == 0) _movement_disable_fast_tick_if_possible();
-    if (movement_state.debounce_ticks_mode > 0 && --movement_state.debounce_ticks_mode == 0) _movement_disable_fast_tick_if_possible();
+    disable_if_needed(&movement_state.debounce_ticks_light);
+    disable_if_needed(&movement_state.debounce_ticks_alarm);
+    disable_if_needed(&movement_state.debounce_ticks_mode);
 }
 
 void cb_light_btn_interrupt(void) {